I still remember how to diagram sentences. I believe it helped me become a better writer, but I don't believe we should make everyone learn it.