General rule of thumb: If you're going to submit a pull request, at least take the time to compile it and run the tests. I don't care if you used AI or not, but a pull request which trivially fails CI is a waste of everyone's time and resources.

I'm more of an AI optimist than a lot of people seem to be on this platform, but even with that, it's important to remember that AI today basically only augments the *typing* part of coding. You still need to think. You still need to read and revise the code. You still need to use all of the same surrounding tools (builds, VCS, style checkers, etc). Copy/pasting issue text into Cursor and blindly submitting the results is unhelpful noise.

Follow

@djspiewak thanks for emphasizing this point, I tend to take it for granted that of course you would also use the other relevant tools and not just AI, but I guess if you start with AI and 'it works' you might not learn about those for a while.
I will note that I have submitted PRs without compiling, but they were 1-10 liners were I didn't want to set up a whole environment to make a change. I find it acceptable to have the CI run the checks on these to get feedback, as I'm not going to go through that loop many times.

@spoltier If you know what you're doing, small PRs are acceptable, but keep in mind that the CI doesn't run automatically for first-time contributors because it's a security risk. So it needs approval from a maintainer, who must review the PR first, possibly wasting their time.

@djspiewak

Sign in to participate in the conversation
Qoto Mastodon

QOTO: Question Others to Teach Ourselves
An inclusive, Academic Freedom, instance
All cultures welcome.
Hate speech and harassment strictly forbidden.